Skip to content

[Infra] Bump podspec min. versions #15015

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 31 commits into from
Jun 24, 2025
Merged

[Infra] Bump podspec min. versions #15015

merged 31 commits into from
Jun 24, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 20, 2025

CocoaPods fix for #14732

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@ncooke3

This comment was marked as outdated.

@ncooke3

This comment was marked as outdated.

@ncooke3

This comment was marked as outdated.

@ncooke3
Copy link
Member Author

ncooke3 commented Jun 23, 2025

RTDB

  • Restarted RTDB integration tests

Integration tests are silently failing in main. Not sure why this PR surfaced them when nightlies didn't. See silent failure in nightlies: https://github.com/firebase/firebase-ios-sdk/actions/runs/15821265434/job/44590876032#step:8:1595

Update: This requires more investigation, but I don't think it should block this PR.

@paulb777
Copy link
Member

Agreed that the RTDB integration tests shouldn't block.

@ncooke3 ncooke3 requested a review from paulb777 June 24, 2025 16:10
@ncooke3
Copy link
Member Author

ncooke3 commented Jun 24, 2025

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done in a separate PR: The deprecateddynamicLinkDomain should be removed and changelogged.

@ncooke3 ncooke3 merged commit a0fd16d into main Jun 24, 2025
453 of 458 checks passed
@ncooke3 ncooke3 deleted the nc/min-os branch June 24, 2025 17:22
@ncooke3 ncooke3 added this to the Firebase 12 - M167 milestone Jun 24, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants