Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update podspecs to min iOS 10 #6517

Merged
merged 12 commits into from
Sep 22, 2020
Merged

Update podspecs to min iOS 10 #6517

merged 12 commits into from
Sep 22, 2020

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 21, 2020 •
edited
Loading

  • Update minimum iOS version across project to iOS 10
  • Only exceptions are Analytics dependencies which are update to iOS 9 to be consistent with AdMob
  • Only library source change is a code deletion from FDL to fix a deprecation warning
  • Similar test change in FIAM
  • Also osx 10.12 to be consistent with minimum Apple versions at 2016

Fix #4847

@paulb777 paulb777 added this to the Firebase 7 milestone Sep 21, 2020
@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Sep 22, 2020
wilhuff
wilhuff approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FirebaseCore/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
# Firebase 7.0.0
- [changed] Update minimum iOS version to iOS 10 except for Analytics which is now iOS 9. (#4847)
- [changed] Update minimum OSX version to 10.12.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple no longer calls this operating system "OSX": it's "macOS".

maksymmalyhin
maksymmalyhin approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulb777
Copy link
Member Author

All tests passed on the penultimate run and are failing after a changelog update because of CocoaPods CDN flakes.

I'm going to merge now and can address additional comments on a subsequent PR.

@paulb777 paulb777 merged commit a39b515 into firebase7-main Sep 22, 2020
@paulb777 paulb777 deleted the pb-min10 branch September 22, 2020 22:11
@paulb777 paulb777 mentioned this pull request Sep 23, 2020
Closed
@ryanwilson ryanwilson mentioned this pull request Sep 29, 2020
Closed
@paulb777 paulb777 mentioned this pull request Sep 29, 2020
Merged
@eldhosembabu eldhosembabu mentioned this pull request Oct 21, 2020
Merged
eldhosembabu added a commit that referenced this pull request Oct 21, 2020
@eldhosembabu
Fixed broken callback to AppDelegate (#6800)
881ba5d 
Fixed broken callback to AppDelegate after retrieving a dynamic link during fresh app start.
The AppDelegate call was broken in PR : #6517

Reverting to the old implementation of dynamic link passing to App delegate with changes to remove iOS 9 checks.
Using new "openURL" method instead of the deprecated one.
Clean up in the sample app pod file.
paulb777 pushed a commit that referenced this pull request Oct 21, 2020
@eldhosembabu @paulb777
Fixed broken callback to AppDelegate (#6800)
5cc4150 
Fixed broken callback to AppDelegate after retrieving a dynamic link during fresh app start.
The AppDelegate call was broken in PR : #6517

Reverting to the old implementation of dynamic link passing to App delegate with changes to remove iOS 9 checks.
Using new "openURL" method instead of the deprecated one.
Clean up in the sample app pod file.
paulb777 added a commit that referenced this pull request Oct 21, 2020
@paulb777 @eldhosembabu
Fixed broken callback to AppDelegate (#6800) (#6801)
4368b98 
Fixed broken callback to AppDelegate after retrieving a dynamic link during fresh app start.
The AppDelegate call was broken in PR : #6517

Reverting to the old implementation of dynamic link passing to App delegate with changes to remove iOS 9 checks.
Using new "openURL" method instead of the deprecated one.
Clean up in the sample app pod file.

Co-authored-by: Eldhose M Babu <eldhosembabu@google.com>
@firebase firebase locked and limited conversation to collaborators Oct 23, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@wilhuff wilhuff wilhuff approved these changes

@christibbs christibbs Awaiting requested review from christibbs

@eldhosembabu eldhosembabu Awaiting requested review from eldhosembabu

Assignees
No one assigned
Labels
api: auth api: core api: dynamiclinks api: firestore api: inappmessaging Firebase In App Messaging cla: yes
Projects
None yet
Milestone
Firebase 7 - M82
Development

Successfully merging this pull request may close these issues.
5 participants
@paulb777 @maksymmalyhin @wilhuff @googlebot @google-oss-bot