Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add support for testing in-app messages in SwiftUI previews #8351

Merged
merged 23 commits into from
Jul 16, 2021
Merged

Add support for testing in-app messages in SwiftUI previews #8351

merged 23 commits into from
Jul 16, 2021

Conversation

christibbs
Copy link
Contributor

@christibbs christibbs commented Jul 8, 2021 •
edited
Loading

In core FIAM SDK: Opens up initializers for image subclasses

  • See changes in FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessagingRendering.h

In core FIAM UI test project, refactor to use open message initializers

  • See changes in test files
    FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/BannerMessageViewController.swift
    FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/ImageOnlyMessageViewController.swift
    FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/ModalMessageViewController.swift
    FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/CardMessageViewController.swift

In FIAM SwiftUI SDK: Adds preview helper methods to create canned in-app messages

  • See changes in new file FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift

In FIAM SwiftUI integration test project: Updates project to use SwiftUI preview helpers

  • See changes in new file FirebaseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/Shared/ModalInAppMessageView.swift

christibbs added 10 commits June 23, 2021 18:58
@christibbs
Expose most of the initializers for message metadata classes for use …
41de67e 
…in unit testing or SwiftUI previews
@christibbs
Fix import in FIRIAMFetchFlowTests
faaacd4
@christibbs
Simplify UI test app to use now public initializers (doesn't build)
12dd3a2
@christibbs
Update public header to use stripped down message initializers that o…
e68fb5b 
…nly include parameters that effect layout
@christibbs
Fix nullability for body text in in-app message initializers, add hel…
af3a536 
…per methods for generating mock messages
@christibbs
Remove default image for image-only convenience initializer
3029356
@christibbs
Make initializers non optional, document force unwraps
4b3e7ae
@christibbs
Finalize helper methods, update test project to use the preview helpers
e91903e
@christibbs
Update UI tests to use new initializers
8559835
@christibbs
Revert Cocoapods related project changes
c12484f
@google-cla google-cla bot added the cla: yes label Jul 8, 2021
@google-oss-bot
Copy link

google-oss-bot commented Jul 8, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    SDK overall coverage changed from 45.31% (6444730) to 46.08% (2d909b5) by +0.77%.

    Filename Base (6444730) Head (2d909b5) Diff
    FIRIAMDisplayExecutor.m 68.73% 68.65% -0.08%
    FIRInAppMessagingRenderingDataClasses.m 62.69% 88.83% +26.15%

Test Logs

ryanwilson
ryanwilson reviewed Jul 12, 2021
View reviewed changes
@christibbs
Copy link
Contributor Author

@ryanwilson Resolved all open items, PTAL!

ryanwilson
ryanwilson approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things with the xcproject but otherwise LGTM. Thanks!

Indiana Jones getting his hat at the last second

@christibbs christibbs merged commit 6e3f659 into master Jul 16, 2021
@christibbs christibbs deleted the fiam-swiftui-previews branch July 16, 2021 20:04
This was referenced Jul 17, 2021
Merged
Open
@firebase firebase locked and limited conversation to collaborators Aug 16, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@eldhosembabu eldhosembabu Awaiting requested review from eldhosembabu

Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging cla: yes public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christibbs @google-oss-bot @ryanwilson