Skip to content

Remove default value for max_attempts argument to RunTransaction(). #9952

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Remove default value for max_attempts argument to RunTransaction(). #9952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Firestore/core/src/api/firestore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,10 @@ class Firestore : public std::enable_shared_from_this<Firestore> {
WriteBatch GetBatch();
core::Query GetCollectionGroup(std::string collection_id);

// TODO(dconeybe): Remove the default value of `max_attempts` once
// the firebase-cpp-sdk has been updated to specify an explicit value.
// The default value for `max_attempts` is `kDefaultTransactionMaxAttempts`.
void RunTransaction(core::TransactionUpdateCallback update_callback,
core::TransactionResultCallback result_callback,
int max_attempts = kDefaultTransactionMaxAttempts);
int max_attempts);

void Terminate(util::StatusCallback callback);
void ClearPersistence(util::StatusCallback callback);
Expand Down