Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: fix the "TextEncoder undefined" issue #8765

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Feb 5, 2025

use platform based newTextEncoder creation instead of calling TextEncoder directly.

@milaGGL milaGGL requested review from a team as code owners February 5, 2025 20:13
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 2600fcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (313faf6)Merge (2909e91)Diff
    browser380 kB381 kB+18 B (+0.0%)
    main589 kB589 kB-2 B (-0.0%)
    module380 kB381 kB+18 B (+0.0%)
    react-native381 kB381 kB+18 B (+0.0%)
  • @firebase/firestore-lite

    TypeBase (313faf6)Merge (2909e91)Diff
    browser112 kB112 kB+77 B (+0.1%)
    main154 kB154 kB+47 B (+0.0%)
    module112 kB112 kB+77 B (+0.1%)
    react-native112 kB112 kB+77 B (+0.1%)
  • bundle

    15 size changes

    TypeBase (313faf6)Merge (2909e91)Diff
    firestore (CSI Auto Indexing Disable and Delete)271 kB271 kB+11 B (+0.0%)
    firestore (CSI Auto Indexing Enable)271 kB271 kB+11 B (+0.0%)
    firestore (Persistence)303 kB303 kB-26 B (-0.0%)
    firestore (Query Cursors)250 kB250 kB-26 B (-0.0%)
    firestore (Query)247 kB247 kB-26 B (-0.0%)
    firestore (Read data once)235 kB235 kB-26 B (-0.0%)
    firestore (Read Write w Persistence)327 kB327 kB-26 B (-0.0%)
    firestore (Realtime updates)237 kB237 kB-26 B (-0.0%)
    firestore (Transaction)214 kB214 kB+11 B (+0.0%)
    firestore (Write data)214 kB214 kB+11 B (+0.0%)
    firestore-lite (Query Cursors)103 kB103 kB+11 B (+0.0%)
    firestore-lite (Query)99.4 kB99.4 kB+11 B (+0.0%)
    firestore-lite (Read data once)74.8 kB74.8 kB+11 B (+0.0%)
    firestore-lite (Transaction)100 kB100 kB+11 B (+0.0%)
    firestore-lite (Write data)84.4 kB84.4 kB+11 B (+0.0%)

  • firebase

    TypeBase (313faf6)Merge (2909e91)Diff
    firebase-compat.js791 kB791 kB-26 B (-0.0%)
    firebase-firestore-compat.js339 kB339 kB-26 B (-0.0%)
    firebase-firestore-lite.js131 kB131 kB+77 B (+0.1%)
    firebase-firestore.js439 kB439 kB+18 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/j4nxXkz9pk.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

This report is too large (356,401 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MD8FBrZ3D4.html

Copy link
Contributor

@dlarocque dlarocque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this on short notice!

@dlarocque
Copy link
Contributor

Merging so that I can re-run staging

@dlarocque dlarocque merged commit 5250e80 into main Feb 5, 2025
47 of 49 checks passed
@dlarocque dlarocque deleted the mila/fix-textEncoder-undefined-bug branch February 5, 2025 21:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants