Emulators:exec should rethrow errors from emulator startup

CHANGELOG.md

@@ -1,2 +1,3 @@
+- Fixes an issue where `emulators:exec` would return a 0 error code when emulators failed to start. (#7974)
 - Added `--import` and `emulators:export` support to the Data Connect emulator.
 - Added `firebase.json#emulators.dataconnect.dataDir`. When set, Data Connect data will be persisted to the configured directory between emulator runs.

src/emulator/commandUtils.ts

@@ -17,7 +17,7 @@
 import * as fsutils from "../fsutils";
 import Signals = NodeJS.Signals;
 import SignalsListener = NodeJS.SignalsListener;
 const Table = require("cli-table");
 import { emulatorSession } from "../track";
 import { setEnvVarsForEmulators } from "./env";
 import { sendVSCodeMessage, VSCODE_MESSAGE } from "../dataconnect/webhook";
@@ -82,7 +82,7 @@
  * specify an emulator address.
  */
 export function printNoticeIfEmulated(
   options: any,
   emulator: Emulators.DATABASE | Emulators.FIRESTORE,
 ): void {
   if (emulator !== Emulators.DATABASE && emulator !== Emulators.FIRESTORE) {
@@ -110,7 +110,7 @@
  * an emulator port that the command actually talks to production.
  */
 export function warnEmulatorNotSupported(
   options: any,
   emulator: Emulators.DATABASE | Emulators.FIRESTORE,
 ): void | Promise<void> {
   if (emulator !== Emulators.DATABASE && emulator !== Emulators.FIRESTORE) {
@@ -150,17 +150,17 @@
  * Utility method to be inserted in the "before" function for a command that
  * uses the emulator suite.
  */
 export async function beforeEmulatorCommand(options: any): Promise<any> {
   const optionsWithDefaultConfig = {
     ...options,
     config: DEFAULT_CONFIG,
   };
   const optionsWithConfig = options.config ? options : optionsWithDefaultConfig;
 
   // We want to be able to run most emulators even in the absence of
   // firebase.json. For Functions and Hosting we require the JSON file since the
   // config interactions can become fairly complex.
   const canStartWithoutConfig =
     options.only &&
     !controller.shouldStart(optionsWithConfig, Emulators.FUNCTIONS) &&
     !controller.shouldStart(optionsWithConfig, Emulators.HOSTING);
@@ -468,8 +468,9 @@
     await sendVSCodeMessage({ message: VSCODE_MESSAGE.EMULATORS_STARTED });
     exitCode = await runScript(script, extraEnv);
     await controller.onExit(options);
-  } catch {
+  } catch (err: unknown) {
     await sendVSCodeMessage({ message: VSCODE_MESSAGE.EMULATORS_START_ERRORED });
+    throw err;
   } finally {
     await controller.cleanShutdown();
   }