Skip to content

Add support for Apple M1 Silicon #281

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
May 10, 2022
Merged

Add support for Apple M1 Silicon #281

merged 7 commits into from
May 10, 2022

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Now that we are building on GHA, we can add support for Apple Silicon chips. This adds logic to the python script to build both x86_64 and arm64, and then merge them together with lipo.


Testing

Describe how you've tested these changes.

Validating that the bundle files have both symbols, and running it locally on an M1 Mac.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

#278

@a-maurice a-maurice requested a review from cynthiajoan May 10, 2022 01:05
@a-maurice a-maurice merged commit fc9b605 into main May 10, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 10, 2022
@github-actions
Copy link

github-actions bot commented May 10, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit fc9b605
Last updated: Tue May 10 17:24 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): Android] [1/2 Test Device(s): android_target]
messaging [TEST] [ERROR] [2019] [macos] [2/5 Platform(s): iOS Android] [All 2 Test Device(s)]
storage [BUILD] [ERROR] [2019] [macos] [All 3 Platform(s)]

@a-maurice a-maurice deleted the am-mac_arm64 branch May 10, 2022 20:31
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 10, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 11, 2022
@firebase firebase locked and limited conversation to collaborators Jun 10, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants