Use google-closure-deps instead of depswriter.py. #839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Closure Library, we will be removing
depswriter.py
and other Python-based build scripts soon.depswriter.py
is superceded bygoogle-closure-deps
, a similar tool we maintain that is implemented in Node.js.Here, I've substituted the
depswriter.py
command with a corresponding command fromgoogle-closure-deps
; the CLI flags are similar. The difference in output is minimal (see below).Explanation of "extra" flags:
--closure-path="node_modules/google-closure-library/closure/goog"
Path to Closure (now required)--file="node_modules/google-closure-library/closure/goog/deps.js"
Use the deps.js file bundled with Closure as part of deps calculation--exclude=...
Not strictly necessary, but prevents these files from being written todeps.js
as trivial, 0-dependency entriesFor reference, the diff of the resulting
deps.js
from runningnpm run generate-test-files
(with lines sorted and formatted for diff clarity) is here.