Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use static $timestamp instead of time() #93

Merged

Conversation

josephmcdermott
Copy link

I am unit testing an application where I want to assert that certain JWT values will in fact be marked as 'expired' or 'not ready' but it is proving difficult due to the dynamic values within JWT::decode() method generated by time().

This PR allows a static property to be specified, fixing the value of 'current time' for the test suite.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@josephmcdermott
Copy link
Author

I signed it!

@josephmcdermott
Copy link
Author

I signed it! (again)

@josephmcdermott
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 3, 2016
@josephmcdermott
Copy link
Author

The Google CLA approval was harder than the code change! :) FYI anybody else, I had to add a commit like this: git commit --author="MY_NAME <MY_GOOGLE_EMAIL_ADDRESS>" -m"..."

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants