Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add tooltip component and show tooltip on action bar item #104

Merged
merged 6 commits into from
Oct 18, 2023
Merged

feat: add tooltip component and show tooltip on action bar item #104

merged 6 commits into from
Oct 18, 2023

Conversation

Dhoni77
Copy link
Contributor

@Dhoni77 Dhoni77 commented Oct 8, 2023

Closes #103

  • Added Tooltip component from mantine library
  • Added tooltip to sidebar

Attachments:
tooltip

@netlify
Copy link

netlify bot commented Oct 8, 2023 •
edited
Loading

‼️ Deploy request for staging-firecamp-dev rejected.

Name Link
🔨 Latest commit 5599571

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Nishchit14 Nishchit14 mentioned this pull request Oct 8, 2023
Closed
@Nishchit14 Nishchit14 self-requested a review October 8, 2023 07:53
Nishchit14
Nishchit14 requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@Nishchit14 Nishchit14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks perfect, i have only suggested some naming convention changes.

thank you for your contribution!!

platform/firecamp-platform/src/components/containers/SidebarContainer.tsx Outdated Show resolved Hide resolved
platform/firecamp-ui/src/components/tooltip/ToolTip.tsx Outdated Show resolved Hide resolved
platform/firecamp-ui/src/components/tooltip/ToolTip.tsx Outdated Show resolved Hide resolved
platform/firecamp-ui/src/components/tooltip/ToolTip.tsx Outdated Show resolved Hide resolved
platform/firecamp-ui/src/components/tooltip/ToolTip.tsx Outdated Show resolved Hide resolved
platform/firecamp-ui/src/components/tooltip/ToolTip.tsx Outdated Show resolved Hide resolved
Nishchit14
Nishchit14 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Nishchit14 Nishchit14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Nishchit14 Nishchit14 merged commit 6ab0cee into firecamp-dev:main Oct 18, 2023
@Nishchit14 Nishchit14 added this to the v3.2.3 milestone Oct 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Nishchit14 Nishchit14 Nishchit14 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
v3.2.3
Development

Successfully merging this pull request may close these issues.

ui: show tooltip on action bar item
3 participants
@Dhoni77 @CLAassistant @Nishchit14