Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix zustand console warnings #88

Conversation

Siddhant-K-code
Copy link
Contributor

@Siddhant-K-code Siddhant-K-code commented Sep 24, 2023

Description

Screenshots (optional)

Before After
image image

Fixes #77

@netlify
Copy link

netlify bot commented Sep 24, 2023

‼️ Deploy request for staging-firecamp-dev rejected.

Name Link
🔨 Latest commit 08791d3

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2023

CLA assistant check
All committers have signed the CLA.

@Nishchit14
Copy link
Contributor

I'll create a separate issue for the second point. Need to review pmndrs/zustand#1180 first.

Copy link
Contributor

@Nishchit14 Nishchit14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review September 24, 2023 16:51
@Siddhant-K-code
Copy link
Contributor Author

I'll create a separate issue for the second point. Need to review pmndrs/zustand#1180 first.

Agreed, let's go ahead and merge this one. We can address the second issue in a subsequent PR. Once this is merged, we'll be down to just one warning, a significant improvement from the initial eight warnings :)

@Nishchit14
Copy link
Contributor

The actual migration guide is written here.

https://docs.pmnd.rs/zustand/previous-versions/zustand-v3-create-context#migration

@Nishchit14
Copy link
Contributor

I'll create a separate issue for the second point. Need to review pmndrs/zustand#1180 first.

Agreed, let's go ahead and merge this one. We can address the second issue in a subsequent PR. Once this is merged, we'll be down to just one warning, a significant improvement from the initial eight warnings :)

Agree, I'll check this in locally once and then merge, probably by the next morning.

@Nishchit14 Nishchit14 merged commit 6d5c751 into firecamp-dev:main Sep 25, 2023
@Nishchit14 Nishchit14 added this to the v3.2.3 milestone Sep 25, 2023
@Siddhant-K-code Siddhant-K-code deleted the siddhant-k-code/fix-zustand-warnings-77 branch September 25, 2023 05:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix zustand warnings
3 participants