Skip to content

Remove addVsocksHandler from loadSnapshotHandlerList #506

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
CuriousGeorgiy opened this issue Aug 24, 2023 · 0 comments · May be fixed by #507
Open

Remove addVsocksHandler from loadSnapshotHandlerList #506

CuriousGeorgiy opened this issue Aug 24, 2023 · 0 comments · May be fixed by #507

Comments

@CuriousGeorgiy
Copy link

According to the firecracker OpenAPI specification 1, creating vsock
devices is only a pre-boot request, so adding vsocks after loading a
snapshot fails. It also seems redundant, since the VM loaded from a
snapshot restores vsocks anyways.

Footnotes

  1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678 ↩
CuriousGeorgiy added a commit to CuriousGeorgiy/firecracker-go-sdk that referenced this issue Aug 24, 2023
@CuriousGeorgiy
Remove addVsocksHandler from loadSnapshotHandlerList
6fe5d92 
According to the firecracker OpenAPI specification [1], creating vsock
devices is only a pre-boot request, so adding vsocks after loading a
snapshot fails. It also seems redundant, since the VM loaded from a
snapshot restores vsocks anyways.

Closes firecracker-microvm#506

1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678

Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
@CuriousGeorgiy CuriousGeorgiy linked a pull request Aug 24, 2023 that will close this issue
Open
CuriousGeorgiy added a commit to CuriousGeorgiy/firecracker-go-sdk that referenced this issue Sep 8, 2023
@CuriousGeorgiy
Remove addVsocksHandler from loadSnapshotHandlerList
57869b1 
According to the firecracker OpenAPI specification [1], creating vsock
devices is only a pre-boot request, so adding vsocks after loading a
snapshot fails. It also seems redundant, since the VM loaded from a
snapshot restores vsocks anyways.

Closes firecracker-microvm#506

1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678

Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
ustiugov pushed a commit to vhive-serverless/firecracker-go-sdk that referenced this issue Sep 10, 2023
@CuriousGeorgiy @ustiugov
Remove addVsocksHandler from loadSnapshotHandlerList
887ea63 
According to the firecracker OpenAPI specification [1], creating vsock
devices is only a pre-boot request, so adding vsocks after loading a
snapshot fails. It also seems redundant, since the VM loaded from a
snapshot restores vsocks anyways.

Closes firecracker-microvm#506

1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678

Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove addVsocksHandler from loadSnapshotHandlerList CuriousGeorgiy/firecracker-go-sdk
1 participant
@CuriousGeorgiy