Re-deprecate --start-time-[cpu-]us flags
#4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
requested review from
xmarcalx,
kalyazin,
pb8o and
wearyzen
as code owners
roypat
added
the
Status: Awaiting review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4500 +/- ##
==========================================
+ Coverage 81.52% 81.54% +0.01%
==========================================
Files 243 243
Lines 29839 29848 +9
==========================================
+ Hits 24327 24340 +13
+ Misses 5512 5508 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulinx86
previously approved these changes
Mar 14, 2024
These flags are used by the jailer to pass the value that should be subtracted from the (CPU) time, when emitting the `start_time_us` and `start_time_cpu_us` metrics. They were never meant to be used by end customers. We cannot print a deprecation message, as the jailer unconditionally passes these two flags to Firecracker. This means that the deprecation message would be printed unconditionally for all users of the jailer. Not passing these flags from the jailer to Firecracker is also not an option, because it would result in a change of behavior (e.g. currently the metrics are only emitted if the flags are passed, so this would need to change to have the metrics be _always_ emitted). Signed-off-by: Patrick Roy <roypat@amazon.co.uk> Co-authored-by: Pablo Barbáchano <pablob@amazon.com>
pb8o
reviewed
Mar 14, 2024
Since some functionality is deprecated without a warning message, it is helpful to have a central location to list all deprecations. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
zulinx86
approved these changes
Mar 15, 2024
pb8o
approved these changes
Mar 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deprecates the
--start-time-cpu-usand--start-time-usCLI arguments and adds aDEPRECATIONS.mdfile.Reason
printing the deprecation message caused an observable change in behavior, so the best we can do is "deprecation via changelog".
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.