Support the case where some visual metrics properties are missing #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3967 +/- ##
=======================================
Coverage 87.26% 87.26%
=======================================
Files 279 279
Lines 23934 23926 -8
Branches 6325 6322 -3
=======================================
- Hits 20885 20879 -6
+ Misses 2809 2807 -2
Partials 240 240
Continue to review full report at Codecov.
|
julienw
force-pushed
the
3966-add-visual-progress-tracks-if-we-have-data
branch
2 times, most recently
from
e619edf to
9b3b206
Compare
julienw
force-pushed
the
3966-add-visual-progress-tracks-if-we-have-data
branch
from
9b3b206 to
227beda
Compare
julienw
force-pushed
the
3966-add-visual-progress-tracks-if-we-have-data
branch
from
227beda to
ab64434
Compare
canova
approved these changes
Apr 1, 2022
| @@ -685,30 +685,30 @@ export type ProgressGraphData = {| | |||
| * along with their visual progression. These properties find their way into the gecko profile through running | |||
| * browsertime, which is a tool that lets you collect performance metrics of your website. | |||
| * Browsertime provides the option of generating a gecko profile, which then embeds these visual metrics | |||
| * into the geckoprofile. More information about browsertime can be found through https://github.com/mozilla/browsertime. | |||
| * into the geckoprofile. More information about browsertime can be found through https://github.com/sitespeedio/browsertime. | |||
| * These values are generated only when browsertime is run with --visualMetrics. | |||
There was a problem hiding this comment.
Thanks for additional information!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3966
production
deploy preview
The data itself in this profile seems to have an error (all "timestamp" properties are undefined) and that's why the resulting graph looks wrong.
I didn't add new tests, because I thought that the type changes are good enough in this case. Tell me what you think :-)