first pass renaming db->ledger #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
best effort was made to understand the context and allow for "datbase" to continue to be used in it's more general context, "document database", "cloud database", etc. also, no files were moved/renamed. this was an intentional choice to avoid breaking links. it has one obvious downside, the URLs for the page about Ledger API will still have a url like /docs/database-api/database
✅ Deploy Preview for dreamy-mermaid-7d2e19 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
As discussed earlier, this pass is just db->ledger. |
this will fix the broken links
jchris
reviewed
Nov 18, 2024
jchris
reviewed
Nov 18, 2024
jchris
reviewed
Nov 18, 2024
jchris
reviewed
Nov 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
best effort was made to understand the context
and allow for "datbase" to continue to be used in it's more general context, "document database", "cloud database", etc.
also, no files were moved/renamed.
this was an intentional choice to avoid breaking links
this has one big downside, the category is still named 'Database API', and I would have changed that to 'Ledger API'
however, docusaurus is auto-generating the side-bar, and I couldn't find a way to separate the label shown from the URLs generated. we can of course also simply update the broken links, if we are not concerned with breaking links outside, or seo.