Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added viewport meta to fix issue in DevTools #2

Merged
merged 1 commit into from Feb 28, 2020
Merged

Added viewport meta to fix issue in DevTools #2

merged 1 commit into from Feb 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2020

Fixes issue #1

@ghost
Copy link
Author

ghost commented Feb 28, 2020

If you resize the browser window the navbar is responsive but if you open the development tools in chrome and choose mobile view, the navbar is not responsive. Add the meta for the viewport should fix this issue like tested locally. Sorry if there's something missing or wrong in my pull-request, this is my first pull-request.

@estevaog3
Copy link
Contributor

Sorry if I forgot something, this is my first pull request.

Nice! I just made my first pull request too hehe

@codediodeio codediodeio merged commit 80767fe into fireship-io:master Feb 28, 2020
@codediodeio
Copy link
Member

Good call, thank you @jurstyx

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants