Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow double quotation marks in plain scalars #253

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 12, 2023

According to the YAML spec, double quotation marks in a plain scalar are allowed. link.
However, fkYAML mistakingly throws an exception against inputs which include such scalars like:

foo: This is "Bar".

So, this PR has fixed the issue and the fix has also been tested by the modified test suite.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Dec 12, 2023
@fktn-k fktn-k added this to the Release v0.3.1 milestone Dec 12, 2023
@fktn-k fktn-k self-assigned this Dec 12, 2023
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 2f589b8 on bugfix/allow_double_quotes_in_plain_scalars
into 4892ae2 on develop.

@fktn-k fktn-k merged commit dc4e22d into develop Dec 12, 2023
107 checks passed
@fktn-k fktn-k deleted the bugfix/allow_double_quotes_in_plain_scalars branch December 12, 2023 16:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants