Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added paths filter to regulate workflow executions #263

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 17, 2023

This PR has added some filters of triggering workflows depending on what kind of files have been changed.
For, previously, all the workflows were activated on every commit regardless of what kind of changes have been made, which forces developers (especially me) to wait for an unnecessary amount of time, for example, modifying only the README file activates the Valgrind check.
So, after merging this PR, commits on main/develop or other branches for PRs will activate the minimum required workflows.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Dec 17, 2023
@fktn-k fktn-k added this to the Release v0.3.1 milestone Dec 17, 2023
@fktn-k fktn-k self-assigned this Dec 17, 2023
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling da28db1 on feature/resolve_overworking_workflows
into 3301e5c on develop.

@fktn-k fktn-k merged commit d53395e into develop Dec 17, 2023
131 checks passed
@fktn-k fktn-k deleted the feature/resolve_overworking_workflows branch December 17, 2023 13:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants