Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix conversions from empty tuples #467

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jan 18, 2025

This PR fixes wrong conversions from std::tuple<> to basic_node.
That was introduced in the PR #465.
std::tuple<> was converted to a null node while an empty sequence was (and still is) converted to std::tuple<>.
Now, std::tuple<> and an empty sequence are guranteed to be converted to each other.

// BEFORE the fix
std::tuple<> t {};
fkyaml::node n = t; // `n` used to be converted as a null scalar node.

// AFTER the fix
fkyaml::node n = t; // `n` is now converted as an empty sequence node.

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Jan 18, 2025
@fktn-k fktn-k added this to the Release v0.4.2 milestone Jan 18, 2025
@fktn-k fktn-k self-assigned this Jan 18, 2025
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 726243f98ee951df3b1aa9ae3c48e9a3904584b8.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr467.zip
ID 2450802877
URL https://github.com/fktn-k/fkYAML/actions/runs/12843389965/artifacts/2450802877

@fktn-k fktn-k merged commit a087743 into develop Jan 18, 2025
163 checks passed
@fktn-k fktn-k deleted the fix_convert_from_empty_tuple_to_node branch January 18, 2025 11:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant