Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix comment prefix check #469

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Fix comment prefix check #469

merged 2 commits into from
Jan 19, 2025

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jan 19, 2025

Although the YAML specification doesn't allow a comment to be followed right after non-break characters, the current lexer implementation doesn't detect such an invalid comment usage.

"foo"# invalid comment

This PR therefore fixes the implementation so the lexer emits an error when the '#' comment prefix doesn't meet all the following checks:

  • it is the first character in the input buffer, or
  • it follows after a white space character ( or \t) or a line break ('\n' or \r\n)

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Jan 19, 2025
@fktn-k fktn-k added this to the Release v0.4.2 milestone Jan 19, 2025
@fktn-k fktn-k self-assigned this Jan 19, 2025
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 3bd79ed54b7bf4b1ff2fb393a9e654a31c94f56e.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr469.zip
ID 2452976946
URL https://github.com/fktn-k/fkYAML/actions/runs/12854724233/artifacts/2452976946

@fktn-k fktn-k merged commit d31189b into develop Jan 19, 2025
163 checks passed
@fktn-k fktn-k deleted the fix_comment_prefix_check branch January 19, 2025 15:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant