Replace getters for reference to node values #481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the following new functions to replace the existing
get_value_ref()
function. See reference pages for each of them for detailed information and example usages.Also,
get_value_ref()
has been deprecated and will be removed in a future update.See migration guide in the reference page for
get_value_ref()
.The reasons for the deprecation:
Although this function seems to take arbitrary types for reference, the accepted types are actually only
(const) sequence_type&
,(const) mapping_type&
,(const) boolean_type&
,(const) integer_type&
,(const) float_number_type&
and(const) string_type&
.Due to explicit reference type specification, the resulting code becomes unnecessarily long and seemingly complex in contrast to the internal implementation, i.e., just returning a reference to an appropriate type.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.