Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor node class implementation #483

Merged
merged 5 commits into from
Feb 9, 2025
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Feb 9, 2025

In this PR the implementation of basic_node temlate class has been refactored, especially the way of resolving anchor/alias references.
Also, custom type traits for the library has been cleaned up since some of them are not used or defined redundantly.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Feb 9, 2025
@fktn-k fktn-k added this to the Release v0.4.3 milestone Feb 9, 2025
@fktn-k fktn-k self-assigned this Feb 9, 2025
Copy link

github-actions bot commented Feb 9, 2025

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit e9b1b05cd758a0b0a645116809d427992c944043.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr483.zip
ID 2560300133
URL https://github.com/fktn-k/fkYAML/actions/runs/13224441997/artifacts/2560300133

@fktn-k fktn-k merged commit c093fc4 into develop Feb 9, 2025
163 checks passed
@fktn-k fktn-k deleted the refactor_node_class_impl branch February 9, 2025 14:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant