wl_list_remove leave wl_listener links invalid, not ffi.NULL #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A listener's link shouldn't be removed more than one time from the signal's wl_list, but it can, and doing so leads to crashes. The existing logic seems to imply that `wl_list_remove` leaves the link as a NULL pointer, blocking subsequent removals. However, the Wayland docs state "Note: This operation leaves elm [the link] in an invalid state. " Instead of relying on that, we should set the object's pointer to `None` and use that to block subsequent removals.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A listener's link shouldn't be removed more than one time from the
signal's wl_list, but it can, and doing so leads to crashes. The
existing logic seems to imply that
wl_list_removeleaves the link as aNULL pointer, blocking subsequent removals. However, the Wayland docs
state "Note: This operation leaves elm [the link] in an invalid state.
" Instead of relying on that, we should set the object's pointer to
Noneand use that to block subsequent removals.Also, the
self.linkattribute looks like forgotten code that should have been removed.