fix!: Make all ComponentSet modifications internal
#1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
st-pasha
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
I think this is good for now, but in the future it would be safer to define ComponentSet interface explicitly, without inheriting from Iterable -- this way we can control the exposed API more tightly. Plus, it could make creating alternative ComponentSet implementations easier.
erickzanardo
approved these changes
Aug 30, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These methods should never have been exposed, since you bypass the component lifecycle with them.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Migration instructions
For most methods
Componenthas the corresponding methods directly on it already.For example, instead of using
component.children.addAllyou should docomponent.addAll.Related Issues
Depends on #1878