This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Create percentual bucketspan vars #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases scenarios, the status panel is used to go from one dashboard to a more specific one, e.g. when performing root/cause analysis. In such cases, the user may want to reduce the scope of the time span, while keeping the desired event centered (to be able to analyse the previous/posterior buckets of time). The status panel does not have dynamically arranged variables to do so, and this is what this PR tries to solve. It is a super-duper simple implementation which comes from the experience. After some tests, we found that 4h bucket span works perfectly with a 7 days dashboard time range, which is a 2.4% of it. This way, the scope and time span of the dashboard can be reduced, acting like a "zoom".
|
@diafour please, let's continue in this PR. Sorry for the inconvenience. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In some cases scenarios, the status panel is used to go from one dashboard to a more specific one, e.g. when performing root/cause analysis. In such cases, the user may want to reduce the scope of the time span, while keeping the desired event centered (to be able to analyse the previous/posterior buckets of time). So, I introduced the variables to be able to do so.
What this PR does / why we need it
The status panel does not have dynamically arranged variables to do so, and this is what this PR tries to solve. It is a super-duper simple implementation which comes from the experience. After some tests, we found that 4h bucket span works perfectly with a 7 days dashboard time range, which is a 2.4% of it.
This way, the scope and time span of the dashboard can be reduced, acting like a "zoom".
Special notes for your reviewer
Does this PR introduce a user-facing change?
NONE