Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(likes): Option to prevent users liking their own posts #3534

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Conversation

imorland
Copy link
Member

Changes proposed in this pull request:

Introduces an option to prevent forum users liking their own posts. Default to allow, as per current behavior.

I've literally lost track of how many times I've been asked to override this, so I believe it makes sense to include the option directly in the extension 🤔

Reviewers should focus on:
I'm not 100% convinced on the translation copy. Does this wording make sense?

Screenshot
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested review from davwheat and SychO9 July 14, 2022 21:06
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy seems fine to me

@davwheat davwheat added this to the 1.5 milestone Jul 14, 2022
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, haven't tested it locally yet. Could we add an integration test for this?

Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 merged commit 54c2145 into main Jul 18, 2022
@SychO9 SychO9 deleted the im/likes branch July 18, 2022 14:32
@luceos luceos mentioned this pull request Jul 30, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants