Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: split FA imports into separate Less file for easy overriding #3535

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jul 15, 2022

Changes proposed in this pull request:

After a good while exploring core, I've not been able to find a way to rip out FontAwesome's imports in our Less. I assume this is because of the weird way it's added as a global import directory within core.

As a result, I've chosen to split out all the FA imports into a new Iconography.less file, which can be overridden using the Less import override extender.

The reason I'm trying to do this is to replace FA5 Free entirely with FA6 Free or FA6 Pro. While importing both does work, it's a huge waste of bundle size. In the meantime, I'll have to override the whole common.less file where FA is imported.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.5 milestone Jul 15, 2022
@davwheat davwheat requested a review from SychO9 July 15, 2022 08:12
@davwheat davwheat self-assigned this Jul 15, 2022
@davwheat davwheat marked this pull request as ready for review July 15, 2022 08:18
@davwheat davwheat merged commit b673d36 into main Jul 15, 2022
@davwheat davwheat deleted the dw/easier-fa-overriding branch July 15, 2022 08:42
@luceos luceos mentioned this pull request Jul 30, 2022
@luceos luceos mentioned this pull request Sep 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants