chore: split FA imports into separate Less file for easy overriding #3535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
After a good while exploring core, I've not been able to find a way to rip out FontAwesome's imports in our Less. I assume this is because of the weird way it's added as a global import directory within core.
As a result, I've chosen to split out all the FA imports into a new
Iconography.less
file, which can be overridden using the Less import override extender.The reason I'm trying to do this is to replace FA5 Free entirely with FA6 Free or FA6 Pro. While importing both does work, it's a huge waste of bundle size. In the meantime, I'll have to override the whole
common.less
file where FA is imported.Necessity
Confirmed
composer test
).