Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add createTableIfNotExists migration helper #3576

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

imorland
Copy link
Member

@imorland imorland commented Aug 1, 2022

Changes proposed in this pull request:
Adds an additional Migration helper - createTableIfNotExists - self explanitory, really.

Reviewers should focus on:
I considered modifying the existing createTable function, with an option 3rd param to specify if this should be conditional, but felt that a seperate, although very similar function, would be clearer in it's intended functionality. Hopefully others will agree?

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested a review from SychO9 August 1, 2022 22:45
@imorland imorland self-assigned this Aug 1, 2022
@imorland imorland added this to the 1.5 milestone Aug 1, 2022
Copy link
Member

@luceos luceos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think this makes sense.

@imorland imorland merged commit 7d3147d into main Aug 2, 2022
@imorland imorland deleted the im/migrations branch August 2, 2022 09:43
@luceos luceos mentioned this pull request Sep 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants