Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: undefined showing in dropdown active title #3700

Merged
merged 2 commits into from
Nov 30, 2022
Merged

fix: undefined showing in dropdown active title #3700

merged 2 commits into from
Nov 30, 2022

Conversation

imorland
Copy link
Member

@imorland imorland commented Nov 27, 2022 •
edited
Loading

#3608 introduced an issue, mainly visible on mobile:

Before
image

After
image

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested a review from a team as a code owner November 27, 2022 21:47
@imorland imorland added this to the 1.7 milestone Nov 27, 2022
@imorland imorland added the javascript Pull requests that update Javascript code label Nov 27, 2022
@davwheat davwheat merged commit 3dd2cad into main Nov 30, 2022
@davwheat davwheat deleted the im/ts-weirdness branch November 30, 2022 16:39
@SychO9 SychO9 removed this from the 1.7 milestone Nov 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imorland @davwheat @SychO9