Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: 3 digit hex color value in color input not supported #3706

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

imorland
Copy link
Member

@imorland imorland commented Dec 5, 2022

Fixes #0000

Changes proposed in this pull request:
When a 3 digit dex color is provided in a color input, the preview remains black, due to the color picker spec requiring 6 digits. To combat this, if a short hex color is provided, convert it.

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested a review from a team as a code owner December 5, 2022 17:07
@imorland imorland self-assigned this Dec 5, 2022
@imorland imorland added the javascript Pull requests that update Javascript code label Dec 5, 2022
@imorland imorland added this to the 1.7 milestone Dec 5, 2022
@SychO9 SychO9 changed the title fix: support 3digit hex color input fix: 3 digit hex color value in color input not supported Dec 5, 2022
@SychO9 SychO9 added the type/bug label Dec 5, 2022
@imorland imorland merged commit 07f8b61 into main Dec 12, 2022
@imorland imorland deleted the im/color-picker branch December 12, 2022 10:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
javascript Pull requests that update Javascript code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants