Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The negate field doesn't get used, which means you cant exclude tags #3713

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

OwenMelbz
Copy link
Contributor

@OwenMelbz OwenMelbz commented Dec 19, 2022

Currently you cannot filter discussions/posts by excluding tag ids, as the $negate boolean is ignored.

/api/posts?sort=-createdAt&filter[tag]=14 to include tag 14

and

/api/posts?sort=-createdAt&filter[tag]=-14 to exclude tag 14


Unless there's a different way to handle this?

e.g. This allows you to

`/api/posts?sort=-createdAt&filter[tag]=14` to include tag 14 and `/api/posts?sort=-createdAt&filter[tag]=-14` to exclude tag 14
@OwenMelbz OwenMelbz requested a review from a team as a code owner December 19, 2022 18:51
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@SychO9 SychO9 merged commit 4bb3b22 into flarum:main Jan 17, 2023
@SychO9 SychO9 added this to the 1.7 milestone Jan 17, 2023
@luceos luceos mentioned this pull request Mar 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants