Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: improve group mentions parsing #3723

Merged
merged 4 commits into from
Jan 22, 2023
Merged

chore: improve group mentions parsing #3723

merged 4 commits into from
Jan 22, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jan 21, 2023 •
edited
Loading

Replaces #3694

Changes proposed in this pull request:

  • Stops from storing the group color class in the database, that's now determined on the frontend side.
  • Removes the isDark utility from the backend, this reduces maintenance and allows us to have a single utility on the frontend which we will augment in the future with additional features.
  • Simplifies some CSS.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 and others added 4 commits January 21, 2023 16:17
@SychO9
chore: improve group mentions color handling
0092684 
* Avoid storing the `GroupMention--dark` and light classes on the database.
* Avoid recreating YIQ logic on the backend.
* Improve text color flexibility through CSS variables.

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@StyleCIBot @SychO9
Apply fixes from StyleCI
0642645
@SychO9
chore: tweak tests
b44f503 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9
chre: unused import
bd08105 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner January 21, 2023 15:27
@SychO9 SychO9 merged commit bf52743 into main Jan 22, 2023
@SychO9 SychO9 deleted the sm/misc-group-mentions-fixes branch January 22, 2023 13:11
@SychO9 SychO9 added this to the 1.7 milestone Jan 22, 2023
@Ornanovitch Ornanovitch mentioned this pull request Jan 22, 2023
Closed
8 tasks
@SychO9 SychO9 added the javascript Pull requests that update Javascript code label Feb 11, 2023
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@luceos luceos luceos approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/cleanup
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @luceos @StyleCIBot