Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update forum.less to fix the misalignment of the choose tags button #3726

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Update forum.less to fix the misalignment of the choose tags button #3726

merged 1 commit into from
Feb 5, 2023

Conversation

iamdarkle
Copy link
Member

Fixes #0000

Changes proposed in this pull request:

This little PR is simply to remove a CSS rule.

I'm not sure of the reason for this vertical-align: 2px; (maybe at some point you had a good reason), but currently this makes the button display misaligned with respect to the Discussion Title input (although in this case it can go unnoticed), but in conjunction with other extensions it's quite noticeable as it's the only misaligned button, as you can see in the case of the screenshot with flamarkt/taxonomies

Reviewers should focus on:

Is there any need to keep the vertical-align: 2px;?

Screenshots

Current with vertical-align: 2px;
Screenshot 2023-02-04 195405

Without vertical-align: 2px; (This PR)
Screenshot 2023-02-04 195425

To add other extensions with which the issue is clearly visible:

  • fof/polls
  • fof/discussion-language

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@iamdarkle iamdarkle requested a review from a team as a code owner February 4, 2023 19:05
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code and less bugs? Sounds like a win to me

@luceos luceos merged commit 5717a74 into flarum:main Feb 5, 2023
@luceos luceos mentioned this pull request Mar 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants