fix(phpstan): adapt phpstan package for extension use #3727
Conversation
- fix "Stub file does not exist" error message as reported in <flarum/docs#441 (comment)> - fix "Ignored error pattern was not matched in reported errors" error messages as reported in <flarum/docs#441 (comment)>
| - "#Relation '[A-z_-]+' is not found in [A-z\_]+ model.#" | ||
| - '#^Parameter \#1 \$query of method [A-z_<>\\]+\:\:union\(\) expects [A-z_<> .,|\\]+ given\.$#' | ||
| - '#^Parameter \#1 \$query of method [A-z_<>\\]+\:\:joinSub\(\) expects [A-z_<> .,|\\]+ given\.$#' | ||
| - message: "#Relation '[A-z_-]+' is not found in [A-z\_]+ model.#" | ||
| reportUnmatched: false | ||
| - message: '#^Parameter \#1 \$query of method [A-z_<>\\]+\:\:union\(\) expects [A-z_<> .,|\\]+ given\.$#' | ||
| reportUnmatched: false | ||
| - message: '#^Parameter \#1 \$query of method [A-z_<>\\]+\:\:joinSub\(\) expects [A-z_<> .,|\\]+ given\.$#' | ||
| reportUnmatched: false |
There was a problem hiding this comment.
rather than ignoring each error individually, let's use the global report unmatched parameter:
https://phpstan.org/user-guide/ignoring-errors#reporting-unused-ignores
There was a problem hiding this comment.
The reason why I chose to ignore each of them instead of using the global parameter, is because I am not sure if it only affects the ignoreErrors of the current file of if it sets it also for user defined ones. I for one, would like to keep it enabled globally, so that my own unmatched ignoreErrors are still reported.
I will quickly check this.
There was a problem hiding this comment.
Indeed, by setting the parameter globally in this file, it also affects the ignoreErrors defined in my own phpstan config file. So I would prefer to keep it as so.
SychO9
changed the title
messages as reported in Document PHPStan usage in extensions docs#441 (comment)