Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(actions): allow running JS tests in GH actions #3730

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Feb 11, 2023

Changes proposed in this pull request:
Now that we have frontend Jest tests (#3678, #3679), we can add the workflow step using (flarum/action-build#12) to take care of it.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner February 11, 2023 12:16
@SychO9 SychO9 added this to the 1.7 milestone Feb 11, 2023
@SychO9 SychO9 merged commit 153bb1a into main Feb 11, 2023
@SychO9 SychO9 deleted the sm/js-tests-workflow branch February 11, 2023 12:19
@luceos luceos mentioned this pull request Mar 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
javascript Pull requests that update Javascript code type/feature type/infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant