Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: hide developer tokens section in if there is nothing to display or create #3753

Merged
merged 5 commits into from
Mar 12, 2023

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Mar 11, 2023

Possible implementation for https://discuss.flarum.org/d/32531-hide-developer-tokens-section-in-security-view-if-user-cant-create-tokens.

It hides this section if user does not have permission to create or moderate tokens, and list of tokens is empty. LoadingIndicator is displayed until list of tokens is loaded.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@rob006 rob006 requested a review from a team as a code owner March 11, 2023 23:04
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@SychO9 SychO9 added this to the 1.7.1 milestone Mar 12, 2023
@SychO9 SychO9 changed the title Hide Developer Tokens section in Security view if there is nothing to display or create chore: hide developer tokens section in if there is nothing to display or create Mar 12, 2023
@SychO9 SychO9 merged commit 661b9d7 into flarum:main Mar 12, 2023
@rob006 rob006 deleted the user-security-page branch March 12, 2023 11:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants