chore: revert uneffective code for encoding of page title #3768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively reverts #3542 and #3684, as both these fixes does not work correctly seems to bring more harm than good. The real issue is described in #3685 and it should be fixed on
trans()
level.Use case:
Flarum & Flarum
.& & & test
.Before this PR title displayed in browser tab would be:
& & & test - Flarum & Flarum
.After this PR:
& & & test - Flarum & Flarum
.Correct title should be:
& & & test - Flarum & Flarum
.While this PR does not fix issue completely, it makes things better. Currently even on Discuss some discussions have incorrectly encoded title:
Necessity
Confirmed
composer test
).Required changes: