Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Integrity constraint violation: 1052 Column 'id' in where clause is ambiguous #3772

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix: Integrity constraint violation: 1052 Column 'id' in where clause is ambiguous #3772

merged 1 commit into from
Mar 21, 2023

Conversation

iPurpl3x
Copy link
Contributor

Changes proposed in this pull request:
Analog to #3696, changed 'id' to 'groups.id' to avoid Column 'id' in where clause is ambiguous error.

This error normally doesn't occur, but if an extension adds an id column to the group_user table, then this error would occur.

(Adding that column helps when one wants to chunkById() on the group_user model)

Reviewers should focus on:
Nothing is broken by this minor change.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@iPurpl3x iPurpl3x requested a review from a team as a code owner March 21, 2023 10:23
@imorland imorland added this to the 1.8 milestone Mar 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants