-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
perf(core,mentions): limit mentionedBy
post relation results
#3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
8 tasks
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
luceos
approved these changes
Apr 4, 2023
imorland
approved these changes
Apr 19, 2023
Closed
10 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3705
Changes proposed in this pull request:
mentionedBy
posts to 4, and allows viewing all the rest in a paginated modal list.mentionedBy
relation by introducing an eager loading callback.mentionedBy
.mentionedPost
filter to grab posts that mention X post.mentionedBy
.Reviewers should focus on:
staudenmeir/eloquent-eager-limit
?: by default, it is not possible to limit a relation's results per model, the point of eager loading is that it queries related models of all models in one query (per relation). If you apply a limit on the relation without package, what you get isn't a limited relation result per model, but a limited relation result for all models. The package introduces the ability to limit relations per model, with a trait.FilterVisiblePosts
class?: it had one goal, to remove invisiblementionedBy
posts from the relation results, by querying the visible IDs of them. This PR just uses a visibility scoper directly on the relatin when limiting results (in an eager load).AbstractModel
andCollection
?: by default Laravel applies a table alias in the subquery of loading an aggregate (count) t void conflicts sincementionedBy
is aPost <-> Post
relation, the problem with that is hat it creates conflicts when using visibility scoping, so the changes here apply an alias on the parent query instead. Readmore details on the new Collection class phpdoc.Screenshot
Necessity
Confirmed
composer test
).