Eager load mentionedBy and only missing relations #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Where'd the extra update come from? |
|
Either SessionAccessToken last_activity_at update or User last_seen_at update which seem to not always run. |
askvortsov1
approved these changes
Mar 22, 2021
tankerkiller125
approved these changes
Mar 22, 2021
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
askvortsov1
pushed a commit
that referenced
this pull request
May 10, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flarum/framework#2637
mentionedByis accessed in the same class a little below but not eager loaded, additionally we want to only eager load relations that weren't loaded before, otherwise it can end up forgetting about the previously eager loaded relations.