Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Missing # from autocompleted user mention format #74

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 18, 2021

Fixes flarum/framework#3112

Changes proposed in this pull request:
A simple missing # from the user mention format on the frontend.

Confirmed

  • Frontend changes: tested on a local Flarum installation.

Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry about that. 🙈

@SychO9
Copy link
Member Author

SychO9 commented Oct 18, 2021

I didn't notice there was a commit for 1.2, I'll rebase this to a new branch and tag v1.1.1 there so that it only retains this change.

@SychO9 SychO9 force-pushed the sm/minor-autocomplete-user-mention-bug branch from 71bdd9e to 5cca2d6 Compare October 18, 2021 19:08
@SychO9 SychO9 changed the base branch from master to v1.1.1 October 18, 2021 19:09
@SychO9 SychO9 merged commit 8ef0ff6 into v1.1.1 Oct 18, 2021
@SychO9 SychO9 deleted the sm/minor-autocomplete-user-mention-bug branch October 18, 2021 19:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mention] impossible to mention when username mention format is disabled
4 participants