Fixed broken discussion list pagination when clicking on the update button

[rafaucau]

Fixes #3111

Changes proposed in this pull request:

This PR fixes a bug with broken pagination after clicking on the update button.
More about the issue: flarum/framework#3111

Can this be released as 1.1.1, please?

Screenshot

2021-12-11.04-38-29.mp4

Necessity

• Has the problem that is being solved here been clearly explained?
• If applicable, have various options for solving this problem been considered?
• For core PRs, does this need to be in core, or could it be in an extension?
• Are we willing to maintain this for years / potentially forever?

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Core developer confirmed locally this works as intended.
• Tests have been added, or are not appropriate here.

[rafaucau]

BTW when I looked in the code for this extension, it is very outdated. As the next PR I might update and improve it. What do you think about it?

[dsevillamartin]

Is the fix removing the false attr by itself or also changing it to app.discussions? Pretty sure we don't want to do the last part for extensibility - I think we switched some things in core to use the attr states recently as well.

[rafaucau]

@datitisev Oh, after removing false it also works. I've corrected it.

[askvortsov1]

Thank you for the PR! This makes sense, not sure why it was false to begin with; this type of error is exactly what TypeScript should help prevent.

BTW when I looked in the code for this extension, it is very outdated. As the next PR I might update and improve it. What do you think about it?

That would definitely be welcomed! Any particular ideas for changes / improvements?

[rafaucau]

@askvortsov1 Any particular ideas for changes / improvements?

• Convert to Typescript
• Update dependencies, e.g. pusher-php-server
• Maybe it would be better to bundle pusher-js into this extension instead of using getScript?

---

• Add information in the discussion that someone is currently writing post. It is useful in hot discussions

[askvortsov1]

@askvortsov1 Any particular ideas for changes / improvements?

• Convert to Typescript

• Update dependencies, e.g. pusher-php-server

• Maybe it would be better to bundle pusher-js into this extension instead of using getScript?

• Add information in the discussion that someone is currently writing post. It is useful in hot discussions

These all seem like great improvements, thank you very much!