Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

nicer make default #35

Merged
merged 1 commit into from
Sep 24, 2024
Merged

nicer make default #35

merged 1 commit into from
Sep 24, 2024

Conversation

metachris
Copy link
Collaborator

📝 Summary

$ make
Usage:
  make <target>

Help
  help             Display this help.
  v                Show the version

Build
  clean            Clean the build directory
  build-cli        Build the CLI
  build-httpserver  Build the HTTP server

Test & Development
  test             Run tests
  test-race        Run tests with race detector
  lint             Run linters
  fmt              Format the code
  gofumpt          Run gofumpt
  lt               Run linters and tests
  cover            Run tests with coverage
  cover-html       Run tests with coverage and open the HTML report
  docker-cli       Build the CLI Docker image
  docker-httpserver  Build the HTTP server Docker image

✅ I have run these commands

  • make lint
  • make test
  • go mod tidy

@MoeMahhouk
Copy link

MoeMahhouk commented Sep 20, 2024

This is a nice addition

Comment on lines -3 to -4
.PHONY: all
all: clean build

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the all target?
usually it is helpful to wrap clean & build in a single make command

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the all tarket is unused because the default is not printing the help

@metachris metachris merged commit 9866063 into main Sep 24, 2024
2 checks passed
@metachris metachris deleted the nice-make branch September 24, 2024 11:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants