bugfix: fix cu118 cub usage #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2024
Merged
yzh119
added a commit
that referenced
this pull request
Jul 31, 2024
## [0.1.3](v0.1.2...v0.1.3) (2024-07-31) ### Bugfix * bugfix: Fix cudagraph mode of BatchPrefillWithRaggedKVCacheWrapper ([#412](#412)) ([9907bc](9907bc1)) * fix cu118 cub usage for sampling kernels ([#410](#410)) ([58d359](58d3593)) ### Misc * enhance allocator error info and add shape check for prefill begin forward functions ([#413](#413)) ([5e36c5](5e36c52))
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: sgl-project/sglang#771
This PR fixes the usage of
FlagHeadscub API in sampling kernels.As documented, the default FlagHeads api will always flag the first element, which is not expected when first element is not
true.This PR sets the
tile_predecessor_itemargument (to 0) which will be compared against input[0].CUDA 12+ don't have this issue because we are using the new
SubtractLeftAPI instead ofFlagHeads.