aws: fix nil pointer exception #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
The details (progress and status message) are not provided by AWS at the beginning of the import. Here's the
details:
```json
{
DiskImageSize: 0,
Format: "RAW",
SnapshotId: "",
Status: "active",
UserBucket: {
S3Bucket: "flatcar-kola-ami-import-us-east-1",
S3Key: "tormath1/amd64-usr/tormath1-flatcar-stable/flatcar_production_ami_image.bin"
}
}
```
Let's just drop it as we don't use it, this does not impact the
execution of the program. If required, we can still access to the task
via its ID using the AWS CLI.
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
chewi
approved these changes
Nov 29, 2024
krnowak
reviewed
Nov 29, 2024
krnowak
approved these changes
Nov 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CI (and locally) we can notice random nil pointer exception during the AWS snapshot creation. In this PR, we just make the code more robust against those errors.
The details (progress and status message) are not provided by AWS at the beginning of the import. Here's the
details:
{ DiskImageSize: 0, Format: "RAW", SnapshotId: "", Status: "active", UserBucket: { S3Bucket: "flatcar-kola-ami-import-us-east-1", S3Key: "tormath1/amd64-usr/tormath1-flatcar-stable/flatcar_production_ami_image.bin" } }Let's just drop it as we don't use it, this does not impact the
execution of the program. If required, we can still access to the task
via its ID using the AWS CLI.