kola: Add checks for SELinux AVC messages #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
force-pushed
the
krnowak/avc-check
branch
from
b3dd673 to
1b7b540
Compare
|
krnowak
force-pushed
the
krnowak/avc-check
branch
from
1b7b540 to
a177543
Compare
krnowak
force-pushed
the
krnowak/avc-check
branch
2 times, most recently
from
83c360f to
ec88c1c
Compare
Kola does some checks after every test run. They are just regexps,
that will cause the test to fail if they match. The regexps are being
run over the contents of the console output and journal. We add
another check to match the AVC denial line ("avc: denied { … } …").
There is a flag to skip the check in case a test wants to actually
generate an AVC and check for it itself.
These start off with an old version of Flatcar and get updated to a new one.
It wasn't exposed through any command-line flag and it seems that it was meant to be always set to true for Flatcar versions greater than 3033, which means anything that is newer than the already unsupported LTS-2022. It is basically a dead code now, so drop it.
When we are running our tests on Github or in Jenkins, we always know what version of Flatcar the image used for testing has. So instead of figuring it out by creating a throw-away cluster, make it possible to provide the image version through a command-line flag. This commit drops the fast-track code-path that was skipping the version query, so in order to avoid the overhead of creating a cluster, passing the version through the command line is required. This also fixes an issue of SELinux AVC not being ignored on older versions of the image if getting the image version from the cluster was for some reason skipped.
krnowak
force-pushed
the
krnowak/avc-check
branch
from
ec88c1c to
b230327
Compare
|
CI results above - I don't think that any failures are related to this PR. |
This was referenced Feb 7, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for SELinux AVC messages in the kola test suite with an option of skipping it.