Dependabot/npm and yarn/frontend/storybook 8.5.x

[ErvinRacz]

Update Storybook Version to 8.5.x

• Refactor story definitions according to the migration guides
• Add new test-runner for storybook as storybook tests (storyshots) have been removed
• Generate the new snapshots and remove old ones snapshots
• Parametrize animated charts to be able to turn their animations off
• New entry in Makefile to integrate the new test runner for storybook
• Update CI runners' base image from 22.04 to 24.04

How to use

Submit new PRs and watch the frontend CI pipeline execution (make ci step).

Testing done

• Locally by running CI=true make ci and inspecting the output
• Letting the GitHub actions to execute the frontend workflow multiple times

[Copilot]

Copilot reviewed 66 out of 66 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/frontend.yml:32

• Using 'continue-on-error: true' might hide failures in the CI process; if this behavior is intentional, consider adding a comment or documentation to explain why it is safe to ignore errors.

continue-on-error: true

Copilot reviewed 69 out of 69 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

frontend/.storybook/test-runner.ts:24

• Consider providing a more descriptive error message that includes additional context (such as which story or page state triggered the error) to aid debugging when '#storybook-root' is not found.

throw new Error("elementHandler is null!");

frontend/.storybook/manager.js:1

• Please verify that replacing the import from '@storybook/addons' with '@storybook/manager-api' aligns with your current Storybook version requirements and that it does not break integrations relying on the legacy API.

import { addons } from '@storybook/manager-api';

frontend/.storybook/main.js:1

• [nitpick] The legacy '.storybook/main.js' configuration file has been entirely removed. Please confirm that all references to this configuration have been updated to use the new 'main.ts' setup to avoid unexpected issues.

module.exports = { ... }

[tormath1]

I think those two commits:

• e80aed7
• 30572e9

Can be squashed? IIUC you just want to add back the docker compose version right?

[ErvinRacz]

I think those two commits:

• e80aed7
• 30572e9

Can be squashed? IIUC you just want to add back the docker compose version right?

Yes. I wanted to see if the CI runner image gets the old docker-compose or newer docker compose as it was giving errors sometimes that the command couldn't be found. Upgrading the runner from ubuntu 22.04 to 24.04 solved the issue in the end and the docker compose command is consistently available now.

[tormath1]

LGTM. It does not impact directly Nebraska itself except maybe for the typescript update. Speaking of which before merging can we squash the last two commits: 3c3b54c and 5ef77d4

[ErvinRacz]

LGTM. It does not impact directly Nebraska itself except maybe for the typescript update. Speaking of which before merging can we squash the last two commits: 3c3b54c and 5ef77d4

Will do so :)