-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Drop Catalyst package.use.force for alternatives #2143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These flags normally need to be temporarily forced during stage1, but we already force them permanently in our profiles. Removing this appears to make build_library/portage redundant, but it will later be used to allow building under QEMU with Catalyst, and it could have other uses too. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
91c2895
to
389610f
Compare
Sorry for messing with the PR - i thought the update-sdk workflow might be able to help here, but its doesnt do a bootstrap necessary to test this. |
Ah, I thought the same, but I see what you mean. I can run it through Jenkins then. |
ader1990
approved these changes
Jul 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Catalyst package.use.force for alternatives
These flags normally need to be temporarily forced during stage1, but we already force them permanently in our profiles.
Removing this appears to make build_library/portage redundant, but it will later be used to allow building under QEMU with Catalyst, and it could have other uses too.
How to use
Build the SDK as usual.
Testing done
I'll run CI now.