Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update k3s sysext example #76

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

kranurag7
Copy link
Contributor

  • with overwrite set to true, butane was complaining and I was not able to transpile the same config to JSON.
  • This also updates the user and group of kubeconfig (/etc/rancher/k3s/k3s.yaml) so that we don't have to use sudo with kubectl commands.

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. While at here, can you fix this example too:

links:
?

It should be like this:

variant: flatcar
version: 1.0.0
storage:
  files:
    # filename needs to be k3s.raw
    - path: /etc/extensions/k3s.raw
      contents:
        source: https://github.com/flatcar/sysext-bakery/releases/download/latest/k3s-v1.29.2+k3s1-x86-64.raw
  links:
    - path: /etc/systemd/system/multi-user.target.wants/k3s-agent.service
      target: /usr/local/lib/systemd/system/k3s-agent.service
      overwrite: true

@tormath1
Copy link
Contributor

tormath1 commented Jul 30, 2024

Hello @kranurag7 would you be interested to continue on this PR? It will close this issue: #80

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
@kranurag7
Copy link
Contributor Author

Hello @kranurag7 would you be interested to continue on this PR? It will close this issue: #80

Completely missed this among noisy GitHub notifications [sorry about that :( ]
I've addressed the comments via https://github.com/kranurag7/sysext-bakery/commit/a853e697a7efcc60926a3dd34096516067b6aeef

@tormath1 tormath1 marked this pull request as ready for review July 30, 2024 14:53
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kranurag7 thanks a lot for fixing this!

@tormath1 tormath1 merged commit 2112078 into flatcar:main Jul 30, 2024
@kranurag7 kranurag7 deleted the kr/fix-k3s-example branch July 30, 2024 15:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants