allow Value::Bytes to be assigned to Schema::Fixed ... #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the tests failed. The all pass when I run locally. It looks like it was an issue with the test system rather than the code. |
|
Hello, sorry for the late reply! Could you try to rebase on master and to run |
|
@flavray merge and formatted, as requested. tests pass locally. we'll see if they are able to run now. there was some permissions error last time. |
flavray
approved these changes
Jan 28, 2021
|
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as long as the length matches. This seems needed to enable Serde and serde-bytes to provide Fixed values.